Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #229: Adding Thumbnail Navigation and no-nav to a Video Resource #129

Open
glenrobson opened this issue Nov 14, 2024 · 8 comments
Open
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This recipe looks at adding two behaviours to a range. Specifically noNav to skip the canvas in the navigation and thumbnail-nav to allow a thumbnail image to be used in a video scrubbing scroll bar.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

@cubap
Copy link

cubap commented Nov 21, 2024

It would be nice to generate some related recipes for this to encourage adoption by viewers, especially in other media resources. A thumbnail nav of audio would be obvious and uncomplicated. Ordering a story of annotations through a manuscript's figures or capitals or exploring the evolution of a theme throughout a resource might be served well with an image-forward navigation rather than the annotation labels that are there now.

@triplingual
Copy link

(Regular disclosure of upvoting my own recipe.)

@nfreire
Copy link

nfreire commented Dec 2, 2024

Interesting recipe.
I suggest only a little change in the description of the use case.
Since the recipe describes two independent uses of "behavior", I suggest changing the use case to (change in bold):

You would like to provide visitors with the ability to navigate a video visually using thumbnails, and possibly exclude from the navigation portions of the video with no meaningful video or audio.

@azaroth42
Copy link
Member

line 78 and 83 have highlights ... which seem like they should be on other lines. (Still +1 but please double check before publishing)

@glenrobson
Copy link
Member Author

Issue 129 (Recipe #229: Adding Thumbnail Navigation and no-nav to a Video Resource)

+1: 13 [JulieWinchester cubap danieltbrennan glenrobson kirschbombe ksclarke mikeapp nfreire regisrob rentonsa robcast triplingual zimeon]
0: 1 [tpendragon]
-1: 0 []
Not TRC: 0 []
Ineligible: 2 [LlGC-iir azaroth42]

Result: 13 / 14 = 0.93

Super majority is in favor, issue is approved

@triplingual
Copy link

line 78 and 83 have highlights ... which seem like they should be on other lines. (Still +1 but please double check before publishing)

I've had self-inflicted challenges with highlighting before and I still don't know why this one is so off. Fixed in IIIF/cookbook-recipes@5c171eb.

@tpendragon
Copy link

I think the recipe's fine, I posted confused here largely because it just felt complex and I couldn't totally wrap my head around it, but didn't want to block on that.

@triplingual
Copy link

We had a conversation, @nfreire and I, and we're going to leave the use case text as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants