Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build library on npm postinstall #1

Open
christophziegler opened this issue Feb 23, 2021 · 0 comments
Open

Build library on npm postinstall #1

christophziegler opened this issue Feb 23, 2021 · 0 comments

Comments

@christophziegler
Copy link
Contributor

christophziegler commented Feb 23, 2021

Currently, the scripts in directory /dist are built from the sources using the typscript compiler tsc and checked into the git repository. This is considered to be a bad style. For one it creates unnecessary overhead (memory + files to track). Much more important, it is not obvious if the files in /dist correspond to the current development status of the sources -- no single source of truth. Actually, the files in /dist should be built after the installation via npm at the user's site, for example by a postinstall script defined in the package.json. However, this approach could not be implemented successfully so far. In consuming services, errors were encountered during build of the docker images when npm attempted to resolve the dependencies or to build the scripts. This behaviour may resolve if the depencies are contained in a public repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant