Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing case in TypeChecker for Ctup for GlobalValue #23

Open
waynee95 opened this issue Aug 7, 2023 · 0 comments · May be fixed by #28
Open

Missing case in TypeChecker for Ctup for GlobalValue #23

waynee95 opened this issue Aug 7, 2023 · 0 comments · May be fixed by #28

Comments

@waynee95
Copy link

waynee95 commented Aug 7, 2023

There's a case missing in type_check_exp for handling GlobalValue

Shouldn't the method be extended with:

  def type_check_exp(self, e, env):
    match e:
        case GlobalValue(id):
            return self.type_check_atm(e, env)
@waynee95 waynee95 linked a pull request Aug 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing case for GlobalValue in type_check Ctup waynee95/python-student-support-code
1 participant
@waynee95