Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser review #1

Open
SupperZum opened this issue Nov 13, 2024 · 2 comments
Open

Parser review #1

SupperZum opened this issue Nov 13, 2024 · 2 comments

Comments

@SupperZum
Copy link

SupperZum commented Nov 13, 2024

Для прохідного:
✔️ ! Brief Description
✔️ ! Project Name
✔️ ! Grammar Rules
✔️ ! Unit Tests
✔️ ! Test Coverage
✔️ ! Core Files
✔️ ! CLI (треба help)

Для максимального:
❌ Error Handling ( Implement proper error handling by using anyhow for tests and thiserror for the library.)
✔️ cargo fmt:
✔️ cargo clippy
✔️ makefile
❌ Completeness
✔️ Including a diagram or grammar in the Readme.md:
✔️ Documentation:
✔️ Publishing

✔️ Курсова може бути зарахована
Бал: 14/20

@Invop
Copy link
Owner

Invop commented Nov 15, 2024

updated:
1.
new grammar rules added
brand = { "(" ~ (ASCII_ALPHA | " ")+ ~ ")" }
description = { "{" ~ (ASCII_ALPHA | ASCII_DIGIT | " ")+ ~ "}" }

updated:
item = { index ~ "." ~ WHITE_SPACE? ~ name ~ WHITE_SPACE? ~ quantity ~ WHITE_SPACE? ~ unit ~ (WHITE_SPACE? ~ brand)? ~ (WHITE_SPACE? ~ description)? }
shopping_list = { SOI ~ ((WHITE_SPACE* ~ (category | item) ~ WHITE_SPACE* ~ NEWLINE?)* ~ EOI) }

Added tests for each grammar rule
3.
help has been updated
image
image

The readme file has been updated

err handling

@SupperZum
Copy link
Author

оновив

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants