You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, looks like github actions are failing and blocking the 5.12.0 release. I did a little bit of digging and jotted down a few things here:
ubuntu-latest: failing because the actions are configured to use node version 14 & min. version required by a dependency is 18.0.0
macos-latest: I'm not familiar with this error. Searching online shows it could be due to any one of a number of reasons. I didn't dig any further though since I think we probably should start by updating the node version first. I believe this will most likely bring up more issues with the action-electron-builder package. Especially since it's quite outdated and is probably incompatible with newer versions of node.
Few more things I noticed while digging:
actions/checkout and actions/setup-node are running v2. Latest is now v4.
the actions' node version is manually set to version 14 - but package.json sets the engines.node version to >=8.0.0. Perhaps it's better to have our node version in sync across the whole ecosystem? P.s. we can use the node-version-file key in our github actions and then point it at package.json or a .nvmrc file, for example.
This fork of action-electron-builder seems to be compatible with v20 of node. I haven't tested it, personally, but thought it was worth bringing up here.
Let me know if you need help investigating or applying any of these changes. For the latter, I'll likely need limited access to the repo to test & tweak by triggering the on release behaviour though.
The text was updated successfully, but these errors were encountered:
Hey, looks like github actions are failing and blocking the 5.12.0 release. I did a little bit of digging and jotted down a few things here:
ubuntu-latest
: failing because the actions are configured to use node version14
& min. version required by a dependency is18.0.0
macos-latest
: I'm not familiar with this error. Searching online shows it could be due to any one of a number of reasons. I didn't dig any further though since I think we probably should start by updating the node version first. I believe this will most likely bring up more issues with theaction-electron-builder
package. Especially since it's quite outdated and is probably incompatible with newer versions of node.Few more things I noticed while digging:
actions/checkout
andactions/setup-node
are runningv2
. Latest is nowv4
.14
- butpackage.json
sets theengines.node
version to>=8.0.0
. Perhaps it's better to have our node version in sync across the whole ecosystem? P.s. we can use thenode-version-file
key in our github actions and then point it atpackage.json
or a.nvmrc
file, for example.package-lock.json
file to the git history - c.f. https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-jsonaction-electron-builder
seems to be compatible with v20 ofnode
. I haven't tested it, personally, but thought it was worth bringing up here.Let me know if you need help investigating or applying any of these changes. For the latter, I'll likely need limited access to the repo to test & tweak by triggering the
on release
behaviour though.The text was updated successfully, but these errors were encountered: