Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including ? in a document ID is interpreted as the beginning of the query string #43

Open
DavidDTA opened this issue Feb 26, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@DavidDTA
Copy link

Document and collection IDs should be made URL-safe

@IzumiSy
Copy link
Owner

IzumiSy commented May 5, 2022

@DavidDTA Can I see the example of this case?

Elm internally handles URI encoding in some ways, so I am just looking for what causes this issue.

@DavidDTA
Copy link
Author

It looks like the elm code does not do as much encoding as one would hope:

Url.Builder.relative ["foo", "ba?r"] [] -- "foo/ba?r"

@DavidDTA
Copy link
Author

It looks like there is an open issue in elm/url for this: elm/url#25

@IzumiSy IzumiSy added the bug Something isn't working label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants