Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle severity is ignored while importing, which leads to unintended blockers #54

Open
dkreuer opened this issue Jan 7, 2025 · 1 comment

Comments

@dkreuer
Copy link

dkreuer commented Jan 7, 2025

While importing a checkstyle report the severity is ignored.

Every checkstyle error is mapped to failure, see

$case->failure = new SourceCaseOutput($type, $error->get('message'), self::getDetails($error));

This leads to severity "blocker" when generating Gitlab-CodeQuality-Json documents which leads to false information in the Gitlab UI.
A better severity may be "info" in these cases (if not being configurable) - or the default level "major" albeit this is even too much for my liking.

For more context: I create a PHP CodeSniffer Checkstyle Report which has warnings as severity "warning" where warnings do not fail the CI job but errors do.

@SmetDenis
Copy link
Member

SmetDenis commented Jan 7, 2025

Hello, @dkreuer

Uh, thanks for the report. I haven't had much experience with Gitlab-CodeQuality-Json. I did the integration based on documentation a long time ago. Maybe their spec has improved and there are new features.

Do you have any sample files for me to play around with?

Perhaps you can do a PR with your enhancement.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants