Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building ubuntu-dev container from bd59002ab8052e4fff28197ff6af53a761fe98b1 fails #431

Closed
olberger opened this issue Feb 7, 2019 · 5 comments

Comments

@olberger
Copy link

olberger commented Feb 7, 2019

After git submodules init && git submodules update, I tried rebuilding the ubuntu-dev container, and got:

  Installing /home/user/.cargo/bin/rg
    Updating git repository `https://github.com/rust-lang-nursery/rust-clippy.git`
  Installing clippy v0.0.212 (https://github.com/rust-lang-nursery/rust-clippy.git#e176324f)
error: binary `cargo-clippy` already exists in destination
Add --force to overwrite
The command '/bin/sh -c cargo install fd-find  && cargo install ripgrep  && cargo +nightly install clippy --git https://github.com/rust-lang-nursery/rust-clippy.git' returned a non-zero code: 101

Hopefuly, this is fixed in later revisions of the dockerfiles, hence the need to update the reference to the valid revision of the submodule ?

Hope this helps,

@jankeromnes
Copy link
Member

Thanks a lot for reporting this issue! I think it should live under https://github.com/JanitorTechnology/dockerfiles/issues/ instead.

Unfortunately, build problems like these with clippy do happen relatively often. Usually, I just wait for them to resolve themselves, but from time to time the install procedures of these Rust components change, so we occasionally need to update our Dockerfiles.

I'll re-trigger a Circle CI build of all our Dockerfiles, to see if we can reproduce this bug.

@jankeromnes
Copy link
Member

Ah, sorry, I misread your comment about the submodule.

It's indeed likely that our submodule is out-of-date. I'll try to update it as well. (I really hope @renovatebot will do that for us one day.)

@jankeromnes
Copy link
Member

Hm, I re-triggered a rebuild of all Janitor Dockerfiles yesterday, and ubuntu-dev seemed to install cargo-clippy just fine, but then it failed during Theia install: JanitorTechnology/dockerfiles#224

So I re-retriggered it, but then it failed again with a different error (nasm install):

Step 27/53 : RUN __NASM_VERSION__="2.14.02"  && mkdir /tmp/nasm  && cd /tmp/nasm  && wget -qOnasm.tar.xz https://www.nasm.us/pub/nasm/releasebuilds/${__NASM_VERSION__}/nasm-${__NASM_VERSION__}.tar.xz  && tar xf nasm.tar.xz  && cd nasm-${__NASM_VERSION__}/  && ./configure  && make  && sudo make install  && sudo rm -rf /tmp/nasm
 ---> Running in 1342368bc9a7
The command '/bin/sh -c __NASM_VERSION__="2.14.02"  && mkdir /tmp/nasm  && cd /tmp/nasm  && wget -qOnasm.tar.xz https://www.nasm.us/pub/nasm/releasebuilds/${__NASM_VERSION__}/nasm-${__NASM_VERSION__}.tar.xz  && tar xf nasm.tar.xz  && cd nasm-${__NASM_VERSION__}/  && ./configure  && make  && sudo make install  && sudo rm -rf /tmp/nasm' returned a non-zero code: 4
Exited with code 4

This error output isn't exactly helpful.

It feels a little like playing roulette, but I'll continue re-triggering and investigating. 🤞

@jankeromnes
Copy link
Member

Wow, https://www.nasm.us/ is actually down. 😧

@jankeromnes
Copy link
Member

https://www.nasm.us/ is back up, and the build seems fixed again. 😄

screenshot 2019-02-18 at 11 24 04

jankeromnes added a commit to jankeromnes/janitor that referenced this issue Feb 18, 2019
notriddle pushed a commit that referenced this issue Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants