-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positives #21
Comments
I was not aware of the Guest mode false positive, thank you. Guest mode seems to effectively be incognito mode in everything but name so this is not surprising, but I do see this as a problem. Unfortunately |
Based on this line
I think this gives higher accuracy in Chrome. The real pool size is computed by the quota = (await navigator.storage.estimate()).quota;
memory = performance.memory.jsHeapSizeLimit / 3;
console.log([quota, memory])
console.log(quota < memory ) |
Scratch that... it did not work on Android. |
@abrahamjuliot were you able to find a more reliable solution to this? |
|
This works where device memory is reliable, but I like the v1.2 solution. quota < (jsHeapSizeLimit / 3)
|| (quota / 1024 ** 3) < (navigator.deviceMemory / 3) |
The message seem to be a widespread issue. The earliest message that I've found like the message from @devarya was from 4 hours ago. I spotted another almost identical message from @devarya here. When I looked into the message from @devarya the image linked to |
From what I see, the Chrome detection is based on
storage quota < physical memory
from here, but this condition is not exclusive to incognito mode. It's also in:quota
<jsHeapSizeLimit
. Example: 3.99GBquota
and 4GBjsHeapSizeLimit
would get detected as incognitoFirefox can also produce false positives if the user disables Service Workers and Push API
dom.serviceWorkers.enabled
dom.push.enabled
The text was updated successfully, but these errors were encountered: