Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera exercise 2 comment nitpick #382

Open
Martysh12 opened this issue Jan 28, 2024 · 0 comments
Open

Camera exercise 2 comment nitpick #382

Martysh12 opened this issue Jan 28, 2024 · 0 comments

Comments

@Martysh12
Copy link

LearnOpenGL/src/1.getting_started/7.6.camera_exercise2/camera_exercise2.cpp

Line 15 in 3e94252

translation[3][0] = -position.x; // Third column, first row

Shouldn't it be "fourth column, first row"?
SuperAoao added a commit to SuperAoao/LearnOpenGL that referenced this issue Apr 11, 2024
@SuperAoao
fix issue: Camera exercise 2 comment nitpick JoeyDeVries#382, correct…
45f2cc8 
…ed minor typo in comment.
JoeyDeVries added a commit that referenced this issue Apr 11, 2024
@JoeyDeVries
Merge pull request #387 from SuperAoao/Branch_master_#382
2eb1fcb 
fix issue: Camera exercise 2 comment nitpick #382
kangkang005 pushed a commit to kangkang005/LearnOpenGL that referenced this issue Sep 24, 2024
@SuperAoao
fix issue: Camera exercise 2 comment nitpick JoeyDeVries#382, correct…
87cb0a7 
…ed minor typo in comment.
kangkang005 pushed a commit to kangkang005/LearnOpenGL that referenced this issue Sep 24, 2024
@JoeyDeVries
Merge pull request JoeyDeVries#387 from SuperAoao/Branch_master_#382
5583a6c 
fix issue: Camera exercise 2 comment nitpick JoeyDeVries#382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martysh12