Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5.1] MenuItem type External Link / URL - Link Rel Attribute is missing #92

Open
pepperstreet opened this issue Mar 8, 2018 · 6 comments

Comments

@pepperstreet
Copy link

pepperstreet commented Mar 8, 2018

Hello, I have tested HELIX3, PROTOSTAR, WARP7 MASTER2, FAVOURITE on [b]Joomla 3.8.5[/b]
Only [b]HELIX3 2.5.1[/b] does [b]not[/b] output the rel attribute.

I had a quick look into the HTML overrides.
Apparently the file is missing the link rel attribute parameter!
../templates/shaper_helix3/html/mod_menu/default_url.php

Related forum topic:
https://www.joomshaper.com/forums/create-a-external-link-menu-with-nofollow-attribute

@TinoAugustine
Copy link

Thanks, @pepperstreet for adding this here.

@pepperstreet
Copy link
Author

No changes in latest Helix3 v2.5.2 ?

@TinoAugustine
Copy link

Hope @JoomShaper team will fix this in the next release :(

@rifatwahid
Copy link
Contributor

rifatwahid commented Jul 11, 2018

Hi,
Could you please try this: create-a-external-link-menu-with-nofollow-attribute? We will include this on next update.

  • Thanks

@pepperstreet
Copy link
Author

pepperstreet commented Jul 11, 2018

Thanks. But there is still an issue with the output.
Values seem to work, but not empty/None.
It outputs an orphaned rel

test_linkrelattribute_nofollow_none

Your file applies to megamenu…
please, remember to fix the HTML override as well!
../templates/shaper_helix3/html/mod_menu/default_url.php
It does not include the parameter.

@rifatwahid
Copy link
Contributor

Hi,
Here is the fix: eecff31

  • Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants