Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pictures are downloaded only using http:// but not https:// #5

Open
ironbone opened this issue Mar 16, 2016 · 2 comments
Open

The pictures are downloaded only using http:// but not https:// #5

ironbone opened this issue Mar 16, 2016 · 2 comments

Comments

@ironbone
Copy link

Hello I use your Weather extension on a page with https access. Unfortunately you download your images using http - so the browser show an information that my web page is not secure - because of your images. Is it possible to change it?

@ironbone ironbone changed the title The pictures are downloaded only using http:// but not httpd:// The pictures are downloaded only using http:// but not https:// Sep 10, 2016
@jdockum
Copy link

jdockum commented Aug 28, 2017

I love the simplicity of this module and it looks great, but this is a major issue. With browsers and search engines beginning to favor https I can't use this module unless it's updated.

@jeremywj
Copy link

jeremywj commented Sep 2, 2017

All you need to do is edit the helper.php file in the module.

Replace this line:

private $iconURL = 'http://l.yimg.com/os/mit/media/m/weather/images/icons/l/%d%s-100567.png';

with this:

private $iconURL = 'https://s.yimg.com/os/mit/media/m/weather/images/icons/l/%d%s-100567.png';

module will now be fully HTTPS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants