Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing email address validation when adding new child #187

Open
ckelwin opened this issue Oct 8, 2023 · 4 comments
Open

Missing email address validation when adding new child #187

ckelwin opened this issue Oct 8, 2023 · 4 comments
Assignees
Labels
🐛 bug Something isn't working bugfix-branch hacktoberfest ⛏️ HacktoberFest contributions
Milestone

Comments

@ckelwin
Copy link
Collaborator

ckelwin commented Oct 8, 2023

Describe the bug
When adding a new child, we're asked to insert an Email but there is no validation in place to ensure it is somewhat valid.

To Reproduce
Steps to reproduce the behavior:

  1. Login as parent.
  2. Click on the (+) button at the bottom right to add a child.
  3. In the Add child page:
  • Child name = A
  • Email = A
  • Click add picture to upload an image
  1. Notice that the child is added.

Expected behavior
Should at least validate that the email address entered complies as valid. There should be some libraries/regex for this.

What needs to be done
Use the same logic for validation already used in sign in flow.
email_validators

@JordyHers JordyHers added 🐛 bug Something isn't working bugfix-branch hacktoberfest ⛏️ HacktoberFest contributions labels Oct 8, 2023
@JordyHers JordyHers added this to the v.2.0.0 milestone Oct 8, 2023
@MaryamMansour
Copy link

Hi , can yo assign me to this issue for hacktoberfest? to validate the email I'll be using regex for validation

@JordyHers
Copy link
Contributor

JordyHers commented Oct 8, 2023

@MaryamMansour Thank you. Surely I can. Can you use the logic implemented in the Sign in flow on TextFields. This should be easy. 😅, You would need local.properties file and google.json files along with the firebase_option.dart. Could you join the server to have them...

https://discord.gg/ZHPQVz45

@MaryamMansour
Copy link

@JordyHers Alright thx, I'll work on it!
I joined the server where I can find them...

@JordyHers
Copy link
Contributor

@MaryamMansour To find the files please goto the how to channel. There you will find the Firebase_options and google-services.json, local properties files.

@JordyHers JordyHers moved this from Backlog to In Progress in Time's up Flutter Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working bugfix-branch hacktoberfest ⛏️ HacktoberFest contributions
Projects
Status: In Progress
Development

No branches or pull requests

3 participants