Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should TestOnPR.yml run more tests? #500

Open
lucaferranti opened this issue Oct 23, 2024 · 1 comment
Open

Should TestOnPR.yml run more tests? #500

lucaferranti opened this issue Oct 23, 2024 · 1 comment
Labels
template: change Related to changes to the template, not the package - for new stuff, use 'addition to template'

Comments

@lucaferranti
Copy link
Contributor

Description

In the current setup, two yaml files to run CI tests are generated

  • Test.yml: Runs on multiple OSs and julia versions (assuming the user chooses to do so of course)
  • TestOnPRs.yml: only runs on latest julia version and ubuntu (even if user selects multiple OSs and julia versions)

What is the rationale for this choice?

To me, would make more sense to run the whole matrix both on main and on PR. The motivation for this is that if a PR introduces an OS-dependent problem (for example, it's not rare for packages using wrappers of C-libraries to fail only on windows) I would prefer to catch this before merging the PR to main.

@abelsiqueira
Copy link
Collaborator

This should be an option, indeed. The rationale is faster development based on the Tulipa project, where running on 1.6+Windows was taking ~2x than latest+Ubuntu.
I've also had requests to run the TestOnPRs on a matrix, and let the user decide the matrix (which is a bit harder with a template, but feasible with manual intervention).

@abelsiqueira abelsiqueira added the template: change Related to changes to the template, not the package - for new stuff, use 'addition to template' label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template: change Related to changes to the template, not the package - for new stuff, use 'addition to template'
Projects
None yet
Development

No branches or pull requests

2 participants