Trigger requires public JuliaLang membership

[maleadt]

It shouldn't, because the bot generally has access to a token to check private membership. Triage team membership should probably be sufficient.

[maleadt]

The culprit is actually GitHub.jl, which ignores comments from non-collaborators: https://github.com/JuliaWeb/GitHub.jl/blob/809994e91a12f8b7b060d6345d9cc6f22d9d6786/src/activity/events.jl#L178-L192

I'm not sure GitHub.jl should do this, it should be up to the caller to determine whether a trigger is authorized...

[vtjnash]

It ignores comments if specified by the user by kwarg, but the bot user nanosoldier only has public access to see the membership list because we did not give it more access

[maleadt]

I know about the kwarg, but I don't think GitHub.jl should be doing this. Regardless of this and the perms to see private membership, I'd like to make it possible to make (public) members of the triage team start Nanosoldier as well.

[DilumAluthge]

Members of the triage team (@JuliaLang/triage) are also members of the JuliaLang organization, so shouldn't it be sufficient to just check for membership in the JuliaLang organization?

[vtjnash]

I think you have to be an admin to see the list of other members on Github?

[DilumAluthge]

I don't think that's the case, at least not if the user has publicized their membership.

[maleadt]

Apparently one doesn't have to be member of JuliaLang at all, anymore. I don't recall making that change, however, how that we support PkgEval on non-julia repositories, we can't just add it back. Maybe it should just check membership of the org that owns the repository being tested?