Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Excessive concurrecy group #109

Closed
giordano opened this issue Jan 4, 2025 · 3 comments
Closed

[CI] Excessive concurrecy group #109

giordano opened this issue Jan 4, 2025 · 3 comments

Comments

@giordano
Copy link
Collaborator

giordano commented Jan 4, 2025

Why this

concurrency:
group: integration-tests-global-lock
cancel-in-progress: ${{ (github.ref == 'refs/heads/staging') || (github.ref == 'refs/heads/trying') }}
? This doesn't even allow running CI for different Julia versions in parallel, doubling total CI time from ~15 minutes to ~30 for no reason.

@giordano
Copy link
Collaborator Author

giordano commented Jan 4, 2025

Introduced by @DilumAluthge in #77 without a motivation.

@DilumAluthge
Copy link
Member

Yeah, we should document why we do this. It is intentional. Our integration tests make a lot of calls to "create content" APIs such as "create a pull request". GitHub enforces "secondary rate limits" on these "create content" APIs. In the past, I had the experience (in RegistryCI and CompatHelper) that if I didn't have a global lock, then when multiple integration test ran, I'd end up hitting those secondary rate limits quite frequently. The global lock is my workaround to reduce the risk of hitting secondary rate limits.

Basically, the same motivation as JuliaRegistries/RegistryCI.jl#589

@giordano
Copy link
Collaborator Author

giordano commented Jan 5, 2025

Basically fixed by #110 by removing the second job.

@giordano giordano closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants