Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safe fallbacks of pow for integer exponents and complex numbers #83

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

devmotion
Copy link
Member

This PR fixes #76 and the following unfortunate behaviour on the master branch:

julia> using NaNMath

julia> -1^2
1

julia> NaNMath.pow(-1, 2)
1.0

julia> 2^2
4

julia> NaNMath.pow(2, 2)
4.0

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (20bd888) to head (f513cbf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   97.05%   96.15%   -0.91%     
==========================================
  Files           1        1              
  Lines         102      104       +2     
==========================================
+ Hits           99      100       +1     
- Misses          3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit a24500f into master Jan 9, 2025
16 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dw/pow_int_complex branch January 9, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow on pow with mixed float and complex args
3 participants