Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a callback mechanism to run custom setup logic on all framework-created QQuickWindow instances #556

Closed
maxime-modulopi opened this issue Dec 18, 2024 · 1 comment · Fixed by #558
Assignees
Milestone

Comments

@maxime-modulopi
Copy link

maxime-modulopi commented Dec 18, 2024

530e045 added a way to do this when new FloatingWindow instances are created.

Unfortunately, it currently cannot be done for other framework-created windows, such as the IndicatorWindow. This has the effect of Qt creating new QRhi instances (and new VkInstance + VkDevice) when new QQuickWindow instances are created, which may confuse the Vulkan Validation Layers and other similar debugging tools.

To remedy that, we would need a similar callback mechanism, but for all QQuickWindow instances created by KDDockWidgets.

@maxime-modulopi maxime-modulopi changed the title Add a callback mechanismdee Add a callback mechanism to set QQuickGraphicsDevice on IndicatorWindow Dec 18, 2024
@maxime-modulopi maxime-modulopi changed the title Add a callback mechanism to set QQuickGraphicsDevice on IndicatorWindow Add a callback mechanism to run custom setup logic on all framework-created QQuickWindow instances Dec 18, 2024
@iamsergio iamsergio self-assigned this Dec 19, 2024
@iamsergio iamsergio added this to the v2.3 milestone Dec 19, 2024
@maxime-modulopi
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants