Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tmdb API key to backend #32

Open
kapcom01 opened this issue Sep 25, 2023 · 2 comments · Fixed by #34
Open

move tmdb API key to backend #32

kapcom01 opened this issue Sep 25, 2023 · 2 comments · Fixed by #34
Assignees
Milestone

Comments

@kapcom01
Copy link
Member

It is not secure to have our key in public. In the future we must move the key to backend, running in a private server.

@kapcom01 kapcom01 added this to the 1.0 milestone Sep 25, 2023
@kapcom01 kapcom01 changed the title move tmdb API key to a backend server move tmdb API key to backend Sep 25, 2023
@jepeteo jepeteo linked a pull request Sep 28, 2023 that will close this issue
@kapcom01 kapcom01 reopened this Oct 7, 2023
@kapcom01
Copy link
Member Author

kapcom01 commented Oct 7, 2023

I think we should make a web server to run on the backend using nodejs: https://nodejs.org/en/docs/guides/getting-started-guide

@kapcom01
Copy link
Member Author

kapcom01 commented Oct 7, 2023

This web server should provide a public API that we can call from rip.js like http://rip_server/get_actor_info instead of using the function anazitisi. The function anazitisi and all its dependencies should be moved to the backend web server because it contains the tmdb key which is private information.

@kapcom01 kapcom01 modified the milestones: 1.0, 0.4 Oct 7, 2023
@kapcom01 kapcom01 self-assigned this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant