Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portability errors and null device crash on macOS for hello_triangle_1_3 #1267

Open
SRSaunders opened this issue Feb 3, 2025 · 3 comments · May be fixed by #1268
Open

Portability errors and null device crash on macOS for hello_triangle_1_3 #1267

SRSaunders opened this issue Feb 3, 2025 · 3 comments · May be fixed by #1268

Comments

@SRSaunders
Copy link
Contributor

The new(ish) hello_triangle_1_3 sample is missing the required portability extension and flag on macOS instance creation, and does not test for null device on sample exit. The latter issue causes a crash on macOS (since Vulkan 1.3 is not yet supported) and stops batch mode which is annoying.

Fix will be supplied in a coming PR.
@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Feb 3, 2025 •
edited
Loading

This was a deliberate choice, as at the time we decided to do this, MoltenVK did not support Vulkan 1.3. Did that change recently?

@SRSaunders SRSaunders linked a pull request Feb 3, 2025 that will close this issue
Open
20 tasks
@SRSaunders
Copy link
Contributor Author

SRSaunders commented Feb 3, 2025 •
edited
Loading

This was a deliberate choice, as at the time we decided to do this, MoltenVK did not support Vulkan 1.3. Did that change recently?

Indeed this sample does not yet run on MoltenVK, but does cause a crash in batch mode on macOS which prematurely terminates the run. Very annoying. My fix simply fixes the crash so the sample starts and terminates cleanly and batch mode runs to completion properly. Small changes.

@SaschaWillems
Copy link
Collaborator

I see. Fixing the crash is obviously a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SaschaWillems @SRSaunders