Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Directory structure issues #396

Closed
emackey opened this issue Dec 4, 2023 · 4 comments
Closed

Directory structure issues #396

emackey opened this issue Dec 4, 2023 · 4 comments
Labels

Comments

@emackey
Copy link
Member

emackey commented Dec 4, 2023

I think some of the recent merges have created problems.

$ ./generate-index.py
WARNING: no model files found for DirectionalLight
WARNING: no screenshot found for SheenDamask
WARNING: no screenshot found for XmpMetadataRoundedCube
@emackey emackey added the bug label Dec 4, 2023
@DRx3D
Copy link
Contributor

DRx3D commented Dec 5, 2023

I checked DirectionalLight and did find a model file. How/what/where is generate-index.py looking for model files?

SheenDamask and XmpMetadataRoundedCube do not have files called screenshot/screenshot.[jpg|png]. I'll push up the missing screenshots.

@javagl
Copy link
Contributor

javagl commented Dec 5, 2023

The DirectionalLight issue was most likely due to the directory names being gltf and gltf-Binary instead of glTF and glTF-Binary. Fix in #397

@DRx3D
Copy link
Contributor

DRx3D commented Dec 15, 2023

Screenshots and binary (for XMP...) files were created. Please review @emackey .

@emackey
Copy link
Member Author

emackey commented Dec 18, 2023

Looks good. No warnings from generate-index.py.

@emackey emackey closed this as completed Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants