Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to project.load_project #21

Open
AdamantLife opened this issue Jun 20, 2020 · 1 comment
Open

Minor update to project.load_project #21

AdamantLife opened this issue Jun 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@AdamantLife
Copy link

Issue and Resolution

deepdanbooru.project.load_project still loads tags using dd.data.load_tags_from_project; as far as I can tell this should simply be updated to load_tags_from_project now that the function has been moved to the project module (other parts of the code were updated to dd.project.load_tags_from_project, so I'm assuming I'm not missing anything).

Background

I was experimenting with the library and was using commands.evaluate_project as a template for writing an evaluation function. My code raised an error on dd.project.load_project(project_path) referencing the noted bug. I applied the mentioned fix and no longer receive the error.

Additional Comments

I've made the change on my fork and can open a Pull Request for the change if that's easier for you.

@KichangKim KichangKim added the enhancement New feature or request label Jun 25, 2020
@KichangKim
Copy link
Owner

I agree that current API is quite incomplete now. I'll improve/rewrite all of APIs in the next version. (no ETA yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants