Oracle service name support

[Ginden]

Problem:
typeorm-model-generator does not support service names for Oracle databases.

This code is used to generate

                config /*Oracle.IConnectionAttributes*/ = {
                    user,
                    password,
                    connectString: `${server}:${port}/${database}`
                };

This code is needed to generate valid connection configuration:

                config /*Oracle.IConnectionAttributes*/ = {
                    user,
                    password,
                    connectString: `${server}:${port}/${serviceName}`, // !
                    database // !
                };

Workaround is to hard code configuration in node_modules/typeorm-model-generator/dist/src/drivers/OracleDriver.js file.

[goughjo02]

Hi @Ginden, I am trying to use this package with an Oracle DB and have tried hard-coding some values into OracleDriver.js but have so far been unsuccessful.

When you are hardcoding this, what is the value of server? Is it 'DEDICATED' or 'SHARED'? I was reading about connection here.

I was looking at source code of typeorm and they seem to allow an override of connectString like this:

connectString: credentials.connectString ? credentials.connectString : credentials.host + ":" + credentials.port + "/" + credentials.sid