Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warden doesn't drop its Deeper Darker drops when also using Affinity #379

Open
Nova-Katt opened this issue Oct 11, 2024 · 4 comments
Open
Assignees
Labels
bug Something isn't working fabric Related to Fabric

Comments

@Nova-Katt
Copy link

Minecraft Version: 1.21
Mod Version: deeperdarker-fabric-1.21-1.3.2.1
Mod Loader: fabric 1.16.5-1.21

Description:
When run together with other mods that alter its drops (Affinity in this case), the Warden doesn't drop its Deeper Darker drops, which means no Carapace, and no Heart, rendering the dimension inaccessible. Affinity is made to inject their drops into other loottables and should work with mods that also add things to its loot table, but Deeper Darker doesn't seem to want that.

To Reproduce:
Steps to reproduce the behavior:

  1. Use both Affinity and Deeper Darker mods.
  2. Slaughter tons of Wardens
  3. Still no Heart of the Deep or Carapace.. I only get Sculk, and Resonance Crystal (Affinity)
  4. The new dimension is thus inaccessible.

Additional context:
I've been talking with the Affinity team (Wisp Forest) on their Discord and they looked into the code and told me to bring it here.
I'll make it simple and quote what they told me, so it's their words right off.

That might potentially be a bug. Looking at Deeper Darkers code it should inject the extra drops into the Warden loot table as expected
They check explictly if the loot table comes from a datapack, which kinda disables that drop. Maybe it counts our loot injection as data? That wold mean it conflicts with Fabric API... which is concerning
I would suggest opening an issue to them. I might be able to do so later (if I remember 🙃). Otherwise, you should report this and link these:
https://github.com/wisp-forest/affinity/blob/main/src/main/java/io/wispforest/affinity/Affinity.java#L111
https://github.com/KyaniteMods/DeeperAndDarker/blob/fabric-1.21/src/main/java/com/kyanite/deeperdarker/DeeperDarker.java#L79

Sooo I thought I'd do that, so here you go. :) Hope we can make this thing work as intended together with Affinity (and possibly other mods that alter the drops of the Warden)

@Nova-Katt Nova-Katt added the bug Something isn't working label Oct 11, 2024
@Pedro270707 Pedro270707 self-assigned this Oct 25, 2024
@NewJumper NewJumper added the fabric Related to Fabric label Nov 6, 2024
@Pedro270707
Copy link
Contributor

I forgot to respond, sorry. I tried Deeper and Darker + Affinity and the opposite happened. Only Deeper and Darker and vanilla items dropped

@Pedro270707
Copy link
Contributor

I'll try again just to be sure

@Pedro270707
Copy link
Contributor

2024-12-12_02 36 17

@Pedro270707
Copy link
Contributor

Pedro270707 commented Dec 12, 2024

I've tested it out without Deeper and Darker (only Affinity) and it seems like the warden doesn't drop anything special in the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric Related to Fabric
Projects
None yet
Development

No branches or pull requests

3 participants