Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to make this method working better [improvement] #1445

Open
github-actions bot opened this issue Aug 1, 2022 · 0 comments
Open

to make this method working better [improvement] #1445

github-actions bot opened this issue Aug 1, 2022 · 0 comments
Labels

Comments

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

  1. to handle a case when literal is false, it's very scary

  2. we really need to be able to handle a situation when replacer isn't defined before (by different reasons)

  3. does this function works fine with components

  4. when something wrong - i want to have a better output about params that we passed

// TODO to make this method working better [improvement]

const ERROR_REPLACER_FUNCTION = (value) =>
  `something wrong with replacer function ${value}`;


// TODO to make this method working better [improvement]
// 1. to handle a case when literal is false, it's very scary
// 2. we really need to be able to handle a situation when replacer isn't defined before (by different reasons)
// 3. does this function works fine with `components` 
// 4. when something wrong - i want to have a better output about params that we passed

function objectBuilder(constant, replacer, literal = false) {
  // TODO add typeof for checking replacer as a function
  // console.log( typeof element.replacer === 'undefined' );
@github-actions github-actions bot added the todo label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants