Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anvil and Combining #33

Open
VQ9 opened this issue Jul 9, 2020 · 2 comments
Open

Anvil and Combining #33

VQ9 opened this issue Jul 9, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@VQ9
Copy link

VQ9 commented Jul 9, 2020

I hate it when my players can't use books and can only apply the enchants directly from the enchantment table

Make it so that books function and that combining works

I considered doing it myself, but I got stuck halfway through and am still struggling and it would be probably if the plugin dev did it since its such a key feature found in literally every other "vanilla feel" custom enchants plugin. I really do appreciate how hard it is to do :/ I tried for like 4-5 weeks straight on my fork 💯 . :( failed... If you could get this done, the plugin would be so much better in my opinion!

Imagine: _______
| Book | | (plus) Epic Diamond Sword
| | ---|--- (can't draw) --------> Epic Diamond Sword with enchant from
-------- | the book

@VQ9 VQ9 added the enhancement New feature or request label Jul 9, 2020
@VQ9
Copy link
Author

VQ9 commented Jul 9, 2020

wow, the picture came out horrible :(
image
This is better, don't look at original diagram :D

@TotallyNotGuy
Copy link

I've actually been working on making books work for quite a bit with my fork, Hacky-AdvancedEnchantments. I got somewhere, so if you want to try to build off that maybe it would be easier? I'm not a very good coder. I got books to properly enchant (sometimes it didn't work? Completely no idea why, but mostly consistent) and I got some enchants to transfer over from books to items, but due to how this plugin is coded it requires basically completely overriding the vanilla enchanting (and now anvil) systems, and books are just messy (they use StoredEnchants instead of just Enchants like a normal item, but AdvancedEnchants are still the same for both.) Maybe I can try working on this again? I kind of gave up a few months back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants