Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World Quest Tab for TWW #11

Open
rhodan412 opened this issue Oct 9, 2024 · 5 comments
Open

World Quest Tab for TWW #11

rhodan412 opened this issue Oct 9, 2024 · 5 comments

Comments

@rhodan412
Copy link

Please consider release of forked WQT for The War Within expansion as frame isn't visible, clickable and some API issues with the most recent Curse version

@possum-enjoyer
Copy link

Hey is it possible to the issues tab on your fork, and also release your fork on curseforge? Thanks for continuing!

@devwrk
Copy link

devwrk commented Oct 16, 2024

Message from the original author LanceDH on Curseforge

_

July 29, 2024 #6601181
In reply to AlexL1118: I'm still very much on an indefinite hiatus, so no updates planned for the Worldsoul Saga.

Regardless of that, don't let me stop you helping each other out. The only thing I don't condone is re-listing an updated fork as a new add-on.

_

@rhodan412
Copy link
Author

rhodan412 commented Oct 17, 2024

Hey is it possible to the issues tab on your fork, and also release your fork on curseforge? Thanks for continuing!

Thank you for the comment, I do enjoy the add-on also that @LanceDH has provided us stretching three expansions. Sorry, but I will not be creating a curseforge for this. As @devwrk highlighted in the above, this add-on is the author's work who has marked it also as "All Rights Reserved." My small contributions are essentially given to the author without expectation of acknowledgement, credit, etc. My contributions with the pull request immediately belong to the author to do with it what they please. I fully intend to respect their rights.

I also don't use the add-on regularly and created only basic fixes to get the add-on functional for the TWW expansion (there are small bugs such as reputation rewards not showing up).

All that said, if I have time I will continue to debug my Pull Request. You may place comments there, but please only state fixes to the code and I request that you don't post bug reports. I am quite busy, having very limited time outside my own enjoyment with my family and time playing the game, as well as working on my own add-ons for World of Warcraft that take priority.

Now, to conclude, this doesn't mean that I won't take time here and there to make adjustments and contributions, and you may certainly post bugs that aren't already known/listed in that comment, but I won't be able to commit to handling the bugs that are reported if I am unsure on a fix for those bugs (each author has their own way of doing things and I'm still only a couple of years into LUA language - many other authors are far more talented at coding than I am or likely will ever be).

So stay tuned, feel free to download the files I have on the pull request listed above. The fork is available for download at the link in the initial comment (which again is just a fork of the author's work and NOT a new/separate add-on)

@devwrk
Copy link

devwrk commented Oct 17, 2024

I also don't use the add-on regularly and created only basic fixes to get the add-on functional for the TWW expansion (there are small bugs such as reputation rewards not showing up).

Sine you mentioned a problem with reputation rewards, I can point you to another active fork with working reputation rewards from @NanMetal WorldQuestTab

@rhodan412
Copy link
Author

Sine you mentioned a problem with reputation rewards, I can point you to another active fork with working reputation rewards from @NanMetal WorldQuestTab

Cool, thank you.

pepedressingroom pushed a commit to pepedressingroom/WorldQuestTab that referenced this issue Dec 24, 2024
Removed time label option and made it a dropdown. Now we have 3 options: none, time label and reward amount. Hope this somewhat works LanceDH#11
Could be improved in a future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants