Aliases that rely on using ex commands do not work on Windows / Git Bash

[wardt7]

• I'm submitting a ...

  • bug report
  • feature request
  • support request

• What is the current behavior?
  Currently, it is impossible to run aliases in scripts/run-aliases.sh that contain ex <container> commands in Windows. This is both due to git bash on windows needing winpty to run docker exec -it commands, but also because executing ex on winpty raises a vi terminal instead of the intended execution in a docker container.

• If the current behavior is a bug, what are the steps to reproduce?

  • Be on Windows OS / Git Bash
  • Up the environment
  • Execute an alias that uses ex in its function (e.g. integration-test <container>)

• What is the expected/proposed behavior?
  The alias is executed successfully

• What is the motivation / use case for changing the behavior?
  Windows developers will not be able to use most aliases otherwise

• Please tell us about your environment:

  • Common-dev-env version: 1.20.0
  • Operating system (and shell, if not the OS default): Windows / Git Bash
  • Ruby version: v2.5+

• Any other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, etc):
  In add-aliases.sh, functions that use ex should have a Windows OS check. If the OS is Windows, then use winpty docker exec -it instead of ex. Otherwise use ex.

This would make a good first issue for someone to pick up, if they have access to a windows machine.