Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-to-docker-compose creates "test" alias over built-in shell function #157

Open
1 of 3 tasks
IWHarvey opened this issue Aug 12, 2024 · 0 comments
Open
1 of 3 tasks

Comments

@IWHarvey
Copy link
Collaborator

IWHarvey commented Aug 12, 2024

  • I'm submitting a ...

    • bug report
    • feature request
    • support request
  • What is the current behavior?
    The add-to-docker-compose function creates an alias called "test". "test" is an existing built-in shell command.

  • If the current behavior is a bug, what are the steps to reproduce?
    Have a running dev-env
    Try to add-to-docker-compose anything (which incidentally gives the error "read:2: bad option -a")
    Then use a run.sh command (repair suffices): "unknown shorthand flag: 'e' in -eq"; it does seem like the rest of the provision is fine, though.

  • What is the expected/proposed behavior?
    Not this?

  • What is the motivation / use case for changing the behavior?
    Unexpected errors are distracting!

  • Please tell us about your environment:

    • Common-dev-env version: 2.3.0
    • Operating system (and shell, if not the OS default): Ubuntu 22.04 in WSL
    • Ruby version: 3.0.2p107
  • Any other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, etc):
    I tried to fix this by renaming the test alias where it's set (line 180, add-aliases.sh) and used (next line), but that just causes errors that the new alias is an unknown command, which leads me to think this never worked and just didn't error because 'test' is a valid command. Suspect add-to-docker-compose hasn't worked in some time.

    About that read error: courtesy of a quick Google - read is a built-in and '-a' is bash, and not valid in zsh (where it is '-A'?). Needs further investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant