Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release tag already exists #82

Open
RobertReaves opened this issue Aug 25, 2017 · 0 comments
Open

Pre-release tag already exists #82

RobertReaves opened this issue Aug 25, 2017 · 0 comments

Comments

@RobertReaves
Copy link
Collaborator

RobertReaves commented Aug 25, 2017

If you have to rebase a pre-released branch with upstream/master there is potential for the package.json's version to be set to what was in master instead of what your pre-release version was at. So you could run into the issue of re-creating an already existing tag. For example:

  1. current master version: 1.0.0
  2. pre-release a minor change so you get: 1.1.0-release.0
  3. master gets updated: 1.0.1, and you want to rebase that work into your pre-release
  4. Rebase your branch but remove your existing pre-release version in your local branch so your package.json version is set to 1.0.1
  5. Try to pre-release a minor change again to pull in the upstream/master changes but your local package.json is set to 1.0.1 instead of your previous pre-release version, so when you pre-release again it tries to generate then 1.1.0-release.0 tag again.

Potential Fix:
Have a check before you attempt to make this tag to see if it already exists and if it does recommend bumping the tag to one higher than the latest version of that tag. So: 1.1.0-release.0 would go to 1.1.0-release.1 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant