-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hidden directory from data #235
Comments
I think that the removing the __MACOSX folder would impact the MacOS users and require separate lesson files. That's my guess, I'm a Windows/Linux user so anything specific to MacOS is a guess for me. That said I don't think a brief explanation would throw the class off course. It might be helpful for new users to know what to ignore based on their OS. |
I think the __MACOSX file is not necessary. But I can test if you want me to. |
@emcaulay If you could test this out that would be very helpful. Not using MacOS I have no idea if that file is necessary. Thank you. |
I tested it, and that part of the file is not necessary. I made a new zip and shared with @jmjamison -- and I think it's free of Mac detritus. Jamie will review next week. |
(I shared a new zip with her via Slack since I can't upload the zip to the repo) |
And I learned something new about MacOS files. |
@jmjamison has this new file been update in this repo? I didn't notice any pull request for it. |
The shell-lesson-data.zip file includes a hidden
__MACOSX
directory that is visible when runningls
in Git Bash (and thus potentially confusing to learners. Ideally, the datafile should be updated to remove this extra cognitive load (and filesize) unless there is a reason it needs to be there.The text was updated successfully, but these errors were encountered: