From 2be9aee9b5636495c1c9c646076d8f3d141ff94f Mon Sep 17 00:00:00 2001
From: Robin Schreiber <robin.schreiber@me.com>
Date: Wed, 13 Dec 2023 12:47:57 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B0:=20change=20component=20browser=20?=
 =?UTF-8?q?update=20mechanism?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Previously we would react to hover events to trigger refreshes, which would lead to glitches in the UI and race conditions between interactions. We now update in response to module changes triggered via lively.notifications.
---
 lively.ide/studio/component-browser.cp.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lively.ide/studio/component-browser.cp.js b/lively.ide/studio/component-browser.cp.js
index acbbcaac5c..4d200d692f 100644
--- a/lively.ide/studio/component-browser.cp.js
+++ b/lively.ide/studio/component-browser.cp.js
@@ -23,6 +23,7 @@ import { joinPath } from 'lively.lang/string.js';
 import { runCommand } from 'lively.shell/client-command.js';
 import ShellClientResource from 'lively.shell/client-resource.js';
 import { StatusMessageError, StatusMessageConfirm } from 'lively.halos/components/messages.cp.js';
+import { unsubscribe, subscribe } from 'lively.notifications/index.js';
 
 class MasterComponentTreeData extends TreeData {
   /**
@@ -816,7 +817,6 @@ export class ComponentBrowserModel extends ViewModel {
         signal: 'onMouseUp',
         handler: 'ensureButtonControls'
       },
-      { signal: 'onHoverIn', handler: 'refresh' },
       {
         signal: 'onMouseUp',
         handler: 'ensureComponentEntitySelected'
@@ -919,6 +919,8 @@ export class ComponentBrowserModel extends ViewModel {
   }
 
   async activate (pos = false) {
+    this._refreshOnLoaded = subscribe('lively.modules/moduleloaded', () => this.refresh(), System);
+    this._refreshOnChanged = subscribe('lively.modules/modulechanged', () => this.refresh(), System);
     this.ui.editButton.visible = config.ide.studio.componentEditViaComponentBrowser;
     this._promise = promise.deferred();
     this.ui.searchInput.focus();
@@ -929,6 +931,8 @@ export class ComponentBrowserModel extends ViewModel {
   onWindowClose () { this.close(); }
 
   close () {
+    unsubscribe('lively.modules/moduleloaded', this._refreshOnLoaded, System);
+    unsubscribe('lively.modules/modulechanged', this._refreshOnChanged, System);
     if (this._promise) this._promise.resolve(null);
   }