Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LevelLogger should expose the underlying slf4j Logger #42

Open
Pyppe opened this issue Aug 6, 2019 · 0 comments · May be fixed by #43
Open

LevelLogger should expose the underlying slf4j Logger #42

Pyppe opened this issue Aug 6, 2019 · 0 comments · May be fixed by #43

Comments

@Pyppe
Copy link

Pyppe commented Aug 6, 2019

Howdy!

IMO there's no reason for the LevelLogger to not expose the underlying logger: org.slf4j.Logger. We use in some parts of our codebase LogstashMarkers to instrument logs with custom JSON fields, and exposing the underlying logger would make this less complicated.
Pyppe added a commit to Pyppe/log4s that referenced this issue Aug 6, 2019
@Pyppe
Expose underlying SLF4J logger in LevelLogger
08d863b 
Closes Log4s#42
@Pyppe Pyppe linked a pull request Aug 6, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose underlying SLF4J logger in LevelLogger Pyppe/log4s
1 participant
@Pyppe