From f6909819ce1f88ad14afca10765fe537fe38b5fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sat, 21 Dec 2024 23:35:12 +0100 Subject: [PATCH 1/7] Migrating to xUnit v3 --- Lombiq.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Tests.csproj b/Lombiq.Tests.csproj index b2b5fab..fdd3984 100644 --- a/Lombiq.Tests.csproj +++ b/Lombiq.Tests.csproj @@ -28,7 +28,7 @@ - + From 87f364163e83c1f3eabee1bc76ac7ff647e6c5e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 22 Dec 2024 02:24:33 +0100 Subject: [PATCH 2/7] Allowing breaking changes --- CompatibilitySuppressions.xml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 CompatibilitySuppressions.xml diff --git a/CompatibilitySuppressions.xml b/CompatibilitySuppressions.xml new file mode 100644 index 0000000..ffcc0bf --- /dev/null +++ b/CompatibilitySuppressions.xml @@ -0,0 +1,25 @@ + + + + + CP0002 + M:Xunit.Abstractions.TestOutputHelperExtensions.WriteLineTimestamped(Xunit.Abstractions.ITestOutputHelper,System.String,System.Object[]) + lib/net8.0/Lombiq.Tests.dll + lib/net8.0/Lombiq.Tests.dll + true + + + CP0002 + M:Xunit.Abstractions.TestOutputHelperExtensions.WriteLineTimestampedAndDebug(Xunit.Abstractions.ITestOutputHelper,System.String,System.Object[]) + lib/net8.0/Lombiq.Tests.dll + lib/net8.0/Lombiq.Tests.dll + true + + + CP0002 + M:Xunit.Abstractions.TestOutputHelperExtensions.WriteOutputTimestampedAndDebug(Xunit.Abstractions.ITestOutputHelper,System.String,System.String) + lib/net8.0/Lombiq.Tests.dll + lib/net8.0/Lombiq.Tests.dll + true + + \ No newline at end of file From c8207be7cc4057f674ca5a9c521f1245541f509a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 3 Jan 2025 04:32:23 +0100 Subject: [PATCH 3/7] Adapting to namespace removal --- Extensions/TestOutputHelperExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Extensions/TestOutputHelperExtensions.cs b/Extensions/TestOutputHelperExtensions.cs index 278a79d..91e0898 100644 --- a/Extensions/TestOutputHelperExtensions.cs +++ b/Extensions/TestOutputHelperExtensions.cs @@ -1,6 +1,6 @@ using Lombiq.Tests.Helpers; -namespace Xunit.Abstractions; +namespace Xunit; public static class TestOutputHelperExtensions { From c3b4c0fba784e9e8565aac3d9d490b093aa79433 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 3 Jan 2025 20:30:53 +0100 Subject: [PATCH 4/7] Referencing xunit.v3.extensibility.core instead of xunit.v3.core --- Lombiq.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Tests.csproj b/Lombiq.Tests.csproj index bf011fa..e33c1e6 100644 --- a/Lombiq.Tests.csproj +++ b/Lombiq.Tests.csproj @@ -28,7 +28,7 @@ - + From 41558c0487d134a5e2e54763f7fa69699be3bb3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 3 Jan 2025 20:33:25 +0100 Subject: [PATCH 5/7] Suppressing breaking changes --- CompatibilitySuppressions.xml | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/CompatibilitySuppressions.xml b/CompatibilitySuppressions.xml index ffcc0bf..c7e7ca8 100644 --- a/CompatibilitySuppressions.xml +++ b/CompatibilitySuppressions.xml @@ -2,22 +2,8 @@ - CP0002 - M:Xunit.Abstractions.TestOutputHelperExtensions.WriteLineTimestamped(Xunit.Abstractions.ITestOutputHelper,System.String,System.Object[]) - lib/net8.0/Lombiq.Tests.dll - lib/net8.0/Lombiq.Tests.dll - true - - - CP0002 - M:Xunit.Abstractions.TestOutputHelperExtensions.WriteLineTimestampedAndDebug(Xunit.Abstractions.ITestOutputHelper,System.String,System.Object[]) - lib/net8.0/Lombiq.Tests.dll - lib/net8.0/Lombiq.Tests.dll - true - - - CP0002 - M:Xunit.Abstractions.TestOutputHelperExtensions.WriteOutputTimestampedAndDebug(Xunit.Abstractions.ITestOutputHelper,System.String,System.String) + CP0001 + T:Xunit.Abstractions.TestOutputHelperExtensions lib/net8.0/Lombiq.Tests.dll lib/net8.0/Lombiq.Tests.dll true From f1190f209d8c0c21543f5dcea4dd2290b7dc13d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 31 Jan 2025 02:32:13 +0100 Subject: [PATCH 6/7] Updating xUnit packages --- Lombiq.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Tests.csproj b/Lombiq.Tests.csproj index a7d7ce2..c7d508d 100644 --- a/Lombiq.Tests.csproj +++ b/Lombiq.Tests.csproj @@ -27,7 +27,7 @@ - + From 92b4ae603b6b28f8b9a4729bd17e8e32bdb9090b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 31 Jan 2025 02:54:48 +0100 Subject: [PATCH 7/7] Fixing analyzer violation --- Integration/Services/TestReverseProxy.cs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Integration/Services/TestReverseProxy.cs b/Integration/Services/TestReverseProxy.cs index 7b86346..21abff7 100644 --- a/Integration/Services/TestReverseProxy.cs +++ b/Integration/Services/TestReverseProxy.cs @@ -59,7 +59,11 @@ await httpForwarder.SendAsync( _webHost = webHostBuilder.Build(); + // This object is managed directly via its public methods and it should be only explicitly shut down and + // disposed by them. +#pragma warning disable MA0040 // Use an overload with a CancellationToken return _webHost.StartAsync(); +#pragma warning restore MA0040 // Use an overload with a CancellationToken } public Task StopAsync() @@ -74,7 +78,11 @@ public Task StopAsync() private async Task StopInternalAsync() { + // This object is managed directly via its public methods and it should be only explicitly shut down and + // disposed by them. +#pragma warning disable MA0040 // Use an overload with a CancellationToken await _webHost.StopAsync(); +#pragma warning restore MA0040 // Use an overload with a CancellationToken _webHost.Dispose(); _webHost = null; }