Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock time incorrectly specified as int #312

Closed
mattloose opened this issue Oct 28, 2023 · 1 comment
Closed

Unblock time incorrectly specified as int #312

mattloose opened this issue Oct 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mattloose
Copy link
Contributor

readfish/src/readfish/_cli_args.py

Line 92 in fabf9bf

type=int,

Unblock time should be specified as a float, not an int. The default specified is a float. Manually setting an alternative float value causes arg parsing to fail.
@mattloose mattloose added the bug Something isn't working label Oct 28, 2023
mattloose added a commit that referenced this issue Oct 28, 2023
@mattloose
Closes issue #312
d0b197e
mattloose added a commit that referenced this issue Nov 6, 2023
@mattloose @Adoni5
Closes issue #312 (#313)
caacb02 
* Closes issue #312

* Changed default for unblock_duration to value in _cli_args
Changed 0.5 in targets.py `Analysis` `__init__` to 0.1 defined in `_cli_args.py`

* Update changelog

* GOD damn IDE just leave markdown numbered lists alone

---------

Co-authored-by: Adoni5 <[email protected]>
@Adoni5
Copy link
Contributor

Adoni5 commented Nov 6, 2023

Closed in #310

@Adoni5 Adoni5 closed this as completed Nov 6, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Readfish Development Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Readfish Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattloose @Adoni5