Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work on windows #2

Open
Mavic129 opened this issue Jul 3, 2017 · 9 comments
Open

doesn't work on windows #2

Mavic129 opened this issue Jul 3, 2017 · 9 comments

Comments

@Mavic129
Copy link

Mavic129 commented Jul 3, 2017

tar on windows doesn't support symlink
spawn is not available on windows

tested on windows 10

@MAVProxyUser
Copy link
Owner

MAVProxyUser commented Jul 3, 2017

https://github.com/MAVProxyUser/P0VsRedHerring/tree/RedHerring4Win will be where this lives.

Current problems:

  1. Symlink support on windows.
  2. Host file write does not work properly.

@hugheaves
Copy link

I got this script working under Windows last night using Cygwin. I changed some of the hard coded paths (i.e. DJI Assistant binary) to be variables, and then configured the variables based on the detected OS.

I've never actually used a private repo on GitHub before. If I fork it and submit a PR, does that make a public copy? Would it be best to just push a branch to this repo containing the changes?

@MAVProxyUser
Copy link
Owner

I believe you can do either Hugh... I plan to flip the Repo to public midnight tonight if all goes as planned. Just trying to hammer some bugs out with beta testers before the gates open.

@MAVProxyUser
Copy link
Owner

feel free to attach a .diff file to this post too...

@HFMan
Copy link

HFMan commented Jul 8, 2017

hugh.. work from a fork. When you are done, you can just do a pull request and this will notify MAVProxyUser he can pull your changes into master.

@MAVProxyUser
Copy link
Owner

@hugheaves
Copy link

@MAVProxyUser, yes, that branch contains your script with some conditional logic to handle Cygwin. I'm guessing there's a native (non-Cygwin) ruby for Windows as well, but as the script made use of the typical unix commands, Cygwin seemed like the "path of least resistance".

P.S. Sorry for the late reply ... I just got back into town after a few days "on the road".

@MAVProxyUser
Copy link
Owner

I need to do some heavy testing, but I believe this patch cleans up windows.
ac04a11

@hugheaves
Copy link

Looks good. I think you can pretty much ignore my branch at this point, as I see that you've got the required cygwin binaries in master, (I was running using a full cygwin install, but that's overkill for this use case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants