Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clf.predict or clf.predict_proba ? #1

Open
tomaszmf opened this issue Aug 31, 2018 · 1 comment
Open

clf.predict or clf.predict_proba ? #1

tomaszmf opened this issue Aug 31, 2018 · 1 comment

Comments

@tomaszmf
Copy link

The explainer._predict_down() method, in line 116 has the following:

target_yhat = self.clf.predict(observation)

But for classification this is always cast to 1.0 or 0.0 (for binary classification), thus making the contributions sum up to 0.0 or 1.0 and not to the predicted probability of the model.

Should the aforementioned line not be changed into:

target_yhat = self.clf.predict_proba(observation)

?

thanks.

@bondyra
Copy link
Contributor

bondyra commented Aug 31, 2018

Yeah, probably. Sadly, I am not accountable for maintenance of this package anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants