Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Scheduler Starts at 2:00 and Ends at 1:00 Instead of 00:00 to 23:59 #541

Open
rania-is opened this issue Sep 24, 2024 · 3 comments
Open

Default Scheduler Starts at 2:00 and Ends at 1:00 Instead of 00:00 to 23:59 #541

rania-is opened this issue Sep 24, 2024 · 3 comments
Assignees
@janoliver20
Labels
bug Something isn't working

Comments

@rania-is
Copy link

rania-is commented Sep 24, 2024 •
edited
Loading

When no schedule is defined for an observation, a default scheduler is automatically added for the entire study duration.
However, it starts at 2:00 AM instead of midnight (00:00) on the first day of the study and ends at 1:00 AM instead of 23:59 on the last day.
@alireza-dhp alireza-dhp added the bug Something isn't working label Oct 21, 2024
@rania-is rania-is mentioned this issue Oct 22, 2024
Closed
@rania-is rania-is changed the title Default scheduler starts at 2:00 instead of 00:00 when no schedule is defined Default Scheduler Starts at 2:00 and Ends at 1:00 Instead of 00:00 to 23:59 Oct 23, 2024
janoliver20 added a commit that referenced this issue Dec 2, 2024
@janoliver20
#541, #555: Refactor imports and optimize date computations
400c6b3 
Switches from require to import statements for consistency and modern syntax in both JavaScript and Vue files. Introduces computed properties for minDate and maxDate to improve date handling and ensure accurate time settings for scheduled events. This enhances code readability and maintains better date boundaries within the scheduler component.
@janoliver20
Copy link

#562

janoliver20 added a commit that referenced this issue Dec 2, 2024
@janoliver20
Merge pull request #562 from MORE-Platform/541-default-scheduler-star…
94e3ed6 
…ts-at-200-and-ends-at-100-instead-of-0000-to-2359

#541, #555: Refactor imports and optimize date computations
@andresgruber
Copy link
Contributor

Default Schedulers now start at 00:00 on the first day and ends at 23:59 on the last day.

@janoliver20 janoliver20 linked a pull request Dec 10, 2024 that will close this issue
#352: Implemented duration limitation for the study duration and the … #564
Merged
@janoliver20 janoliver20 removed a link to a pull request Dec 10, 2024
#352: Implemented duration limitation for the study duration and the … #564
Merged
@alireza-dhp
Copy link
Member

Hi @andresgruber,

When I add a new observation and no schedule is defined, it still starts at 1:00 AM instead of midnight (00:00) on the first day of the study and ends at 1:00 AM instead of 23:59 on the last day!

@alireza-dhp alireza-dhp reopened this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janoliver20 janoliver20

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/541-default-scheduler-starts-at-200-and-ends-at-100-instead-of-0000-to-2359 MORE-Platform/more-studymanager-frontend
4 participants
@andresgruber @janoliver20 @rania-is @alireza-dhp