[Briefing] Ajout des images de la carte au pdf #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximeperraultdev
force-pushed
the
maxime/brief/add_map_to_pdf
branch
5 times, most recently
from
8a9cec4 to
3778445
Compare
|
@claire2212 Tu peux relire d'un point de vue technique pour que ça aille plus vite. ll faut qu'on fasse quelques aller retours ux/ui car j'ai quelques questions que j'ai mis dans le chan mattermost |
maximeperraultdev
force-pushed
the
maxime/brief/add_map_to_pdf
branch
from
3778445 to
659faa1
Compare
maximeperraultdev
force-pushed
the
maxime/brief/add_map_to_pdf
branch
from
da5ad7f to
8ec8588
Compare
claire2212
reviewed
Jan 6, 2025
| renderOrder: (a, b) => b.get('area') - a.get('area'), | ||
| source: layersVectorSourceRef.current, | ||
| style: feature => getDashboardStyle(feature), | ||
| zIndex: Layers.DASHBOARD.zIndex |
There was a problem hiding this comment.
Layers.EXPORT_PDF.zIndex plutôt?
claire2212
reviewed
Jan 6, 2025
| ) | ||
| } | ||
|
|
||
| const StyledLinkButton = styled(Button)<{ $isDisabled: boolean }>` | ||
| const StyledLinkButton = styled(Button)<{ disabled: boolean }>` |
There was a problem hiding this comment.
il faut préfixer les props de style par un $ (demandé par styled-component)
There was a problem hiding this comment.
Il me semble que c'est pour les props qui ne doivent pas se retrouver dans le DOM. Et la props disabled est autorisé :)
claire2212
force-pushed
the
maxime/brief/add_map_to_pdf
branch
from
957310c to
33a4b62
Compare
…r zoom and export all features
Bumps the non-major-dev-dependencies group in /frontend with 9 updates: | Package | From | To | | --- | --- | --- | | [@import-meta-env/cli](https://github.com/runtime-env/import-meta-env/tree/HEAD/packages/cli) | `0.7.1` | `0.7.2` | | [@import-meta-env/unplugin](https://github.com/runtime-env/import-meta-env/tree/HEAD/packages/unplugin) | `0.6.0` | `0.6.2` | | [@swc/core](https://github.com/swc-project/swc) | `1.9.3` | `1.10.4` | | [cypress](https://github.com/cypress-io/cypress) | `13.16.0` | `13.17.0` | | [dotenv](https://github.com/motdotla/dotenv) | `16.4.5` | `16.4.7` | | [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) | `7.37.2` | `7.37.3` | | [lint-staged](https://github.com/lint-staged/lint-staged) | `15.2.10` | `15.3.0` | | [type-fest](https://github.com/sindresorhus/type-fest) | `4.29.0` | `4.31.0` | | [vite-tsconfig-paths](https://github.com/aleclarson/vite-tsconfig-paths) | `5.1.3` | `5.1.4` | Updates `@import-meta-env/cli` from 0.7.1 to 0.7.2 - [Release notes](https://github.com/runtime-env/import-meta-env/releases) - [Changelog](https://github.com/runtime-env/import-meta-env/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/runtime-env/import-meta-env/commits/cli0.7.2/packages/cli) Updates `@import-meta-env/unplugin` from 0.6.0 to 0.6.2 - [Release notes](https://github.com/runtime-env/import-meta-env/releases) - [Changelog](https://github.com/runtime-env/import-meta-env/blob/main/packages/unplugin/CHANGELOG.md) - [Commits](https://github.com/runtime-env/import-meta-env/commits/cli0.6.2/packages/unplugin) Updates `@swc/core` from 1.9.3 to 1.10.4 - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](swc-project/swc@v1.9.3...v1.10.4) Updates `cypress` from 13.16.0 to 13.17.0 - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v13.16.0...v13.17.0) Updates `dotenv` from 16.4.5 to 16.4.7 - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v16.4.5...v16.4.7) Updates `eslint-plugin-react` from 7.37.2 to 7.37.3 - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.37.2...v7.37.3) Updates `lint-staged` from 15.2.10 to 15.3.0 - [Release notes](https://github.com/lint-staged/lint-staged/releases) - [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md) - [Commits](lint-staged/lint-staged@v15.2.10...v15.3.0) Updates `type-fest` from 4.29.0 to 4.31.0 - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v4.29.0...v4.31.0) Updates `vite-tsconfig-paths` from 5.1.3 to 5.1.4 - [Release notes](https://github.com/aleclarson/vite-tsconfig-paths/releases) - [Commits](aleclarson/vite-tsconfig-paths@v5.1.3...v5.1.4) --- updated-dependencies: - dependency-name: "@import-meta-env/cli" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: non-major-dev-dependencies - dependency-name: "@import-meta-env/unplugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: non-major-dev-dependencies - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: non-major-dev-dependencies - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-minor dependency-group: non-major-dev-dependencies - dependency-name: dotenv dependency-type: direct:development update-type: version-update:semver-patch dependency-group: non-major-dev-dependencies - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch dependency-group: non-major-dev-dependencies - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-minor dependency-group: non-major-dev-dependencies - dependency-name: type-fest dependency-type: direct:development update-type: version-update:semver-minor dependency-group: non-major-dev-dependencies - dependency-name: vite-tsconfig-paths dependency-type: direct:development update-type: version-update:semver-patch dependency-group: non-major-dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…r zoom and export all features
maximeperraultdev
force-pushed
the
maxime/brief/add_map_to_pdf
branch
from
886b598 to
7d06623
Compare
maximeperraultdev
force-pushed
the
maxime/brief/add_map_to_pdf
branch
from
7d06623 to
89d5fb5
Compare
maximeperraultdev
force-pushed
the
maxime/brief/add_map_to_pdf
branch
from
46da7ca to
90c6127
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues