Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on C2M2 Search Portal #379

Open
5 of 7 tasks
u8sand opened this issue Nov 25, 2024 · 4 comments
Open
5 of 7 tasks

Feedback on C2M2 Search Portal #379

u8sand opened this issue Nov 25, 2024 · 4 comments
Assignees

Comments

@u8sand
Copy link
Contributor

u8sand commented Nov 25, 2024

image

  • I don't think we should have urls to the external resource at this stage of the search results, they are available in the next page
  • I think it might be more intuitive/useful to make clicking the attributes add to the filters, rather than go to the ontology IRIs..

image

  • "Download all" here makes it seem like you're downloading the files.. but this basically just downloads the files.tsv. I suggest using the term "download manifest" or something to make that clear.
  • Given that it's "Copy DRS bundle" I suggest a clipboard icon instead of a download icon
  • the file sizes should probably use locale-specific rendering (i.e. show kb/mb/gb/tb)
  • the raw checksums can probably be truncated
  • the "format:3989" means nothing to the typical user, resolve the actual label behind the ontology IRIs like it was done for assay type/data type
u8sand added a commit that referenced this issue Nov 25, 2024
@u8sand
Copy link
Contributor Author

u8sand commented Nov 25, 2024

Note that I just pushed a new icon for the DRS bundle
image

@u8sand
Copy link
Contributor Author

u8sand commented Dec 2, 2024

image

  • access URL is meant to be the accessible one, persistent id is not necessarily a url (?) thus I think access URL should be the clickable link, and NOT persistent id

@mano-at-sdsc
Copy link
Collaborator

Thanks, @u8sand . I agree. When the persistent ID looks like a URL, can we use the hyperlink there too. @susrinivasan / @shivaramakrishna99 Please see the above suggestion and make the needed change in record_info.

@susrinivasan
Copy link
Collaborator

susrinivasan commented Dec 11, 2024

Hi Daniel, Thanks for all the suggestions for improvement. Regarding issues 1 and 2, we had a discussion in our group and we feel that the Assets column adds a summary like information and when we use terms that can be hyperlinked, we hyperlink it. As to changing its behaviour to filter the results, we surmised that allowing filtering to happen at two different places in the same page would not be a desirable and hence we decided not to implement suggestions #1 and #2. We have fixed all other issues and request you to pull in our changes from the C2M2 branch. If you agree, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants