Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load time message during pagination #397

Open
shivaramakrishna99 opened this issue Dec 17, 2024 · 4 comments
Open

Load time message during pagination #397

shivaramakrishna99 opened this issue Dec 17, 2024 · 4 comments
Assignees
Labels

Comments

@shivaramakrishna99
Copy link
Collaborator

Overlay a helpful "loading" message on the results when page numbers in the pagination section is clicked. This can be useful in case the pagination action takes too long/times out.

image
@mano-at-sdsc
Copy link
Collaborator

mano-at-sdsc commented Dec 17, 2024

Thanks, @shivaramakrishna99 This issue is also relevant for tables on the record info page, so, will add that tag.

@mano-at-sdsc mano-at-sdsc added the C2M2-Record C2M2-Record label Dec 17, 2024
@susrinivasan
Copy link
Collaborator

Can you please post the URL that caused this loading page delay? It is easier to debug that way. Since the filters are not shown, I cannot even make out what filters are used. Judging by the number of records, I guess the search was Parkinsons and I could get to this page. Pagination works very fast and the pages are loading instantaneously on my end and I do not see a need for any overlay. I suggest we close this issue.

@mano-at-sdsc
Copy link
Collaborator

mano-at-sdsc commented Jan 10, 2025

Just to give another example, same speed issue in the file table (going to one page to another) on https://ucsd-sslab.ngrok.app/data/c2m2/search/record_info?q=liver&t=dcc_name:Illuminati[…]7Cdata_type_name:Unspecified%7Cassay_type_name:Unspecified

See if how we did it for the review page: https://data.cfde.cloud/review?schema_name=ercc&table_name=biosample might help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants