Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIT branch #5

Open
m0nsky opened this issue Oct 6, 2024 · 2 comments
Open

MIT branch #5

m0nsky opened this issue Oct 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@m0nsky
Copy link

m0nsky commented Oct 6, 2024

I think it would be great to see a separate branch which does not bundle espeak-ng-data, so games making use of this package can stay MIT and leave it up to the end user to download espeak-ng-data (or use another phonemizer) to enable optional TTS.

@Macoron
Copy link
Owner

Macoron commented Oct 6, 2024

Thank you for your suggestion.

I don't have in-depth understanding about this licenses. From what I understand: if you had linked your code (statically or dynamically) to GPLv3 library, your code also became GPLv3. Because compiled Unity project is linked to compiled espeak .dll (even if you don't distribute it), I don't think your suggestion would work.

Probably most important, I just want to make sure that people are aware that they are using a GPLv3 compiled library of espeak in their project.

Much better solution would be replacing or removing espeak dependency.

@Macoron Macoron added the enhancement New feature or request label Oct 6, 2024
@m0nsky
Copy link
Author

m0nsky commented Oct 6, 2024

I won't be providing the espeak-ng.dll library with the game either, I will only bundle piper-phonemize (MIT license) which will have support for epitran in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants