Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing redundant Waterloo API logic in relation to getting term names from term codes #319

Open
sai3000pro opened this issue Jan 30, 2025 · 1 comment
Open

Replacing redundant Waterloo API logic in relation to getting term names from term codes #319

sai3000pro opened this issue Jan 30, 2025 · 1 comment
Assignees
@sai3000pro

Comments

@sai3000pro
Copy link
Contributor

This issue is an extension off of #316 - a function called convertTermCodeToTermName was implemented, but there is now a lot of redundant code with the Waterloo API logic that should be removed (since it doesn't work).
@sai3000pro sai3000pro self-assigned this Jan 30, 2025
@sai3000pro
Copy link
Contributor Author

I guess a question I have now is what would be considered redundant? Is everything involving the Waterloo API broken? For example, validateTerm goes through the file that was returned by getTermNames, overwriteTermFiles overwrites these names in case validateTerm fails...

I can test these out later this week but wanted to ask in case anyone knew!

@sai3000pro sai3000pro changed the title Replacing redundant Waterloo API logic in relation to convertTermCodeToTermName Replacing redundant Waterloo API logic in relation to getting term names from term codes Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sai3000pro sai3000pro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/319-replacing-redundant-waterloo-api-logic-in-relation-to-converttermcodetotermname MathSoc/mathsoc-website
1 participant
@sai3000pro