Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADR for keyring to allow adding an account non-sequentially #5154

Open
mikesposito opened this issue Jan 15, 2025 · 0 comments
Open

Comments

@mikesposito
Copy link
Member

mikesposito commented Jan 15, 2025

Currently, our Keyring type only allows adding new accounts sequentially, or more specifically, does not provide a standardized way to specify which index (or even derivation path) should be used to derive the next available account.

This is fine for our current hierarchical deterministic wallet mechanics as users are only allowed to derive sequential indexes, but presents a limit for hardware device interactions since:

  • Users can preview the derivable accounts in a paginated manner
  • Users can select specific indexes to derive, which are not required to be sequential

This limitation is currently worked around by clients, that interact directly with each keyring that is known to support specific methods to handle pagination and to set derivation path index, but it would be nice to have a standard way to support this (e.g. through new methods on the shared Keyring type or by creating a pagination helper wrapper)

We should propose a solution to this problem through an ADR.

@desi desi changed the title Create ADR for keyring type-agnostic non-sequential account unlock API Create ADR for keyring to allow adding an account non-sequentially Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants