Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry] Error: No keyring found for the requested account. Error info: There are no keyrings #20317

Open
sentry-io bot opened this issue Jul 31, 2023 · 10 comments
Assignees
Labels
area-Sentry error reporting to sentry regression-prod-10.25.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts team-wallet-framework type-bug

Comments

@sentry-io
Copy link

sentry-io bot commented Jul 31, 2023

Sentry Issue: METAMASK-WQNC

Error: No keyring found for the requested account. Error info: There are no keyrings
  at MetamaskController.getAccountType (app/scripts/metamask-controller.js:2491:5)
  at TransactionController._buildEventFragmentProperties (app/scripts/controllers/transactions/index.js:2460:7)
  at TransactionController._trackTransactionMetricsEvent (app/scripts/controllers/transactions/index.js:2645:25)
@gauthierpetetin
Copy link
Contributor

Events in past 14 days: 306

@gauthierpetetin
Copy link
Contributor

When a user tries to send a transaction or sign a message, MetaMask fetches the private key for the account from its keyring. This error means that no such keyring exists for the account in question.

@danjm
Copy link
Contributor

danjm commented Aug 11, 2023

@danjm
Copy link
Contributor

danjm commented Aug 11, 2023

This is a duplicate of #16193, but there is a great repro shared on that thread

@danjm
Copy link
Contributor

danjm commented Aug 11, 2023

Also see #14652

Copy link
Author

sentry-io bot commented Aug 15, 2024

Sentry Issue: METAMASK-XB5P

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Aug 18, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Aug 18, 2024
@gauthierpetetin gauthierpetetin added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts and removed team-extension-platform labels Aug 19, 2024
@seaona
Copy link
Contributor

seaona commented Oct 8, 2024

Just encountered this issue in 12.3.0 version, find repro steps below

no-keyrings.mp4

Repro:

  1. Connect to the test dapp
  2. Trigger a tx
  3. Disable the Extension right away
  4. Re-enable the Extension
  5. See error

@gauthierpetetin
Copy link
Contributor

gauthierpetetin commented Jan 14, 2025

This PR shall mitigate this issue (at least partially): #29599

@mikesposito
Copy link
Member

This error is thrown if almost any KeyringController method is called while the wallet is locked: https://github.com/MetaMask/core/blob/af90e6780c66cfdc734d6482c87a597c4c4deb36/packages/keyring-controller/src/KeyringController.ts#L942

This seems to be compatible with the reproduction steps shared in this issue and in this one

@desi
Copy link
Contributor

desi commented Jan 27, 2025

MetaMask/core#5171 will give us clarity around this issue so we will wait to see the results of that work to return to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry error reporting to sentry regression-prod-10.25.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts team-wallet-framework type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

8 participants