From f4f7c79be87697edc576b6810795bf1f51ae850f Mon Sep 17 00:00:00 2001
From: "runway-github[bot]"
<73448015+runway-github[bot]@users.noreply.github.com>
Date: Thu, 16 Jan 2025 15:13:24 -0700
Subject: [PATCH] chore(runway): cherry-pick chore: Scope PortfolioView feature
flag to iOS devices only (#13040)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
- chore: Scope PortfolioView feature flag to iOS devices only (#13039)
## **Description**
Scopes the PortfolioView feature flag to only be true for iOS devices,
while we do more troubleshooting on the performance bottleneck on
Android devices.
## **Related issues**
Performance related bug ticket:
https://github.com/MetaMask/metamask-mobile/issues/12679
## **Manual testing steps**
1. Run app with feature flag: `PORTFOLIO_VIEW='true' yarn watch:clean`
2. On iOS device, PortfolioView should be enabled
3. On Android device, PortfolioView should not be enabled
## **Screenshots/Recordings**
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[7f8d095](https://github.com/MetaMask/metamask-mobile/commit/7f8d0955af01b0bf87d0aac1142086f4cd57f2c3)
Co-authored-by: Nick Gambino <35090461+gambinish@users.noreply.github.com>
---
app/util/networks/index.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/util/networks/index.js b/app/util/networks/index.js
index 461f8ea6b87..51cfed908a0 100644
--- a/app/util/networks/index.js
+++ b/app/util/networks/index.js
@@ -14,6 +14,7 @@ import { ChainId, NetworkType, toHex } from '@metamask/controller-utils';
import { toLowerCaseEquals } from '../general';
import { fastSplit } from '../number';
import { regex } from '../../../app/util/regex';
+import Device from '../../util/device';
/* eslint-disable */
const ethLogo = require('../../images/eth-logo-new.png');
@@ -498,4 +499,4 @@ export const isPermissionsSettingsV1Enabled =
process.env.MM_PERMISSIONS_SETTINGS_V1_ENABLED === 'true';
export const isPortfolioViewEnabled = () =>
- process.env.PORTFOLIO_VIEW === 'true';
+ Device.isIos() && process.env.PORTFOLIO_VIEW === 'true';