[Bug]: Send transaction screen is not fully loaded via deeplink #12689
Assignees
Labels
regression-RC-7.38.0
Regression bug that was found in release candidate (RC) for release 7.38.0
release-7.39.0
Issue or pull request that will be included in release 7.39.0
release-blocker
This bug is blocking the next release
Sev1-high
An issue that may have caused fund loss or access to wallet in the past & may still be ongoing
team-confirmations
Push issues to confirmations team
type-bug
Something isn't working
Comments
metamaskbot
added
the
regression-RC-7.38.0
christopherferreira9
added
Sev1-high
|
Present on Android: Payment.request.deep.link.mov |
|
Is this the same issue as: #9260 ? Or something different? |
@bschorchit , this seems a bit different as this one does not require a chain to be provided in the deeplink. |
|
Present on v7.38.0 (1523) Screen.Recording.2025-01-10.at.17.33.51.mov |
christopherferreira9
added
the
release-blocker
|
@Unik0rnMaggie the issue you're testing is the same as this one: #9260 that is pre-existing. Would you mind testing on v7.38 and on a previous version without specifying a network as @christopherferreira9 mentioned? This will help us confirm that this new scenario is indeed a regression. |
7 tasks
|
Hi @bschorchit and team! Tested on v7.38.0 (1524) from here without specifying chain ID and it's the same behavior:
v7.38.0.without.chain.ID.-.click.on.deeplink.movv7.38.0.without.chain.ID.-.scan.QR.movTested on v7.37.1 from here and it works with our without chain ID: v7.37.1.without.chain.ID.click.on.deeplink.movv7.37.1.without.chain.ID.scan.QR.movv7.37.1.with.chain.ID.click.on.deeplink.movv7.37.1.with.chain.ID.scan.QR.mov |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 15, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix deeplinks using `Send` flow. ## **Related issues** Fixes: #12689 ## **Manual testing steps** 1. Open safari/chrome in the testing device - navigate https://metamask.github.io/metamask-deeplinks/ 2. Click "Payment Request" then "Eth Payment" 3. Fill the form - you dont need to put chain id 4. Click "Generate url" 5. Click generated url 6. See that it opens send flow page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/ec6324b0-188f-4079-90ee-3d30b7e6056d ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.39.0
runway-github bot
added a commit
that referenced
this issue
Jan 15, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix deeplinks using `Send` flow. ## **Related issues** Fixes: #12689 ## **Manual testing steps** 1. Open safari/chrome in the testing device - navigate https://metamask.github.io/metamask-deeplinks/ 2. Click "Payment Request" then "Eth Payment" 3. Fill the form - you dont need to put chain id 4. Click "Generate url" 5. Click generated url 6. See that it opens send flow page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/ec6324b0-188f-4079-90ee-3d30b7e6056d ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
added a commit
that referenced
this issue
Jan 15, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix deeplinks using `Send` flow. ## **Related issues** Fixes: #12689 ## **Manual testing steps** 1. Open safari/chrome in the testing device - navigate https://metamask.github.io/metamask-deeplinks/ 2. Click "Payment Request" then "Eth Payment" 3. Fill the form - you dont need to put chain id 4. Click "Generate url" 5. Click generated url 6. See that it opens send flow page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/ec6324b0-188f-4079-90ee-3d30b7e6056d ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
pushed a commit
that referenced
this issue
Jan 15, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix deeplinks using `Send` flow. ## **Related issues** Fixes: #12689 ## **Manual testing steps** 1. Open safari/chrome in the testing device - navigate https://metamask.github.io/metamask-deeplinks/ 2. Click "Payment Request" then "Eth Payment" 3. Fill the form - you dont need to put chain id 4. Click "Generate url" 5. Click generated url 6. See that it opens send flow page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/ec6324b0-188f-4079-90ee-3d30b7e6056d ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
OGPoyraz
added a commit
that referenced
this issue
Jan 15, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix deeplinks using `Send` flow. ## **Related issues** Fixes: #12689 ## **Manual testing steps** 1. Open safari/chrome in the testing device - navigate https://metamask.github.io/metamask-deeplinks/ 2. Click "Payment Request" then "Eth Payment" 3. Fill the form - you dont need to put chain id 4. Click "Generate url" 5. Click generated url 6. See that it opens send flow page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/ec6324b0-188f-4079-90ee-3d30b7e6056d ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sethkfman
pushed a commit
that referenced
this issue
Jan 15, 2025
- fix: Fix `send` flow deeplinks (#12965) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix deeplinks using `Send` flow. ## **Related issues** Fixes: #12689 ## **Manual testing steps** 1. Open safari/chrome in the testing device - navigate https://metamask.github.io/metamask-deeplinks/ 2. Click "Payment Request" then "Eth Payment" 3. Fill the form - you dont need to put chain id 4. Click "Generate url" 5. Click generated url 6. See that it opens send flow page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/ec6324b0-188f-4079-90ee-3d30b7e6056d ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [249e035](249e035) Co-authored-by: OGPoyraz <[email protected]>
OGPoyraz
added a commit
that referenced
this issue
Jan 16, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR cherry picks #12965 into `release/7.38.0` ## **Related issues** Fixes: #12689 ## **Manual testing steps** N/A ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> N/A ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
nickewansmith
pushed a commit
that referenced
this issue
Jan 17, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix deeplinks using `Send` flow. ## **Related issues** Fixes: #12689 ## **Manual testing steps** 1. Open safari/chrome in the testing device - navigate https://metamask.github.io/metamask-deeplinks/ 2. Click "Payment Request" then "Eth Payment" 3. Fill the form - you dont need to put chain id 4. Click "Generate url" 5. Click generated url 6. See that it opens send flow page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/ec6324b0-188f-4079-90ee-3d30b7e6056d ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Describe the bug
Starting a transaction from a deeplink doesn't fully load the send transaction screen.
Expected behavior
The transaction screen is fully loaded with all parameters
Screenshots/Recordings
Screen.Recording.2024-12-13.at.11.28.21.AM.mov
Steps to reproduce
Error messages or log output
Detection stage
During release testing
Version
7.38.0
Build type
None
Device
iPhone 11
Operating system
iOS
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: