-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add user earning history graph and list on history button click #12746
feat: add user earning history graph and list on history button click #12746
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
575cbe2
to
6072e09
Compare
Bitrise❌❌❌ Commit hash: 512a37e Note
Tip
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
512a37e
to
81e1a9a
Compare
Bitrise❌❌❌ Commit hash: 81e1a9a Note
Tip
|
baf57c2
to
d843584
Compare
Bitrise🔄🔄🔄 Commit hash: d843584 Note
|
d843584
to
4938ac2
Compare
Bitrise❌❌❌ Commit hash: 4938ac2 Note
Tip
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12746 +/- ##
==========================================
+ Coverage 60.89% 61.17% +0.27%
==========================================
Files 1917 1935 +18
Lines 42708 43087 +379
Branches 5788 5850 +62
==========================================
+ Hits 26007 26357 +350
- Misses 14937 14955 +18
- Partials 1764 1775 +11 ☔ View full report in Codecov by Sentry. |
5a531de
to
81f023a
Compare
664fd36
to
99c6f19
Compare
Bitrise✅✅✅ Commit hash: 99c6f19 Note
|
…cker in staking history view
Bitrise✅✅✅ Commit hash: 659183c Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One non-blocking suggestion
...ings/StakingEarningsHistory/StakingEarningsHistoryChart/StakingEarningsHistoryChart.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assets changes LGTM
Description
This PR adds a pooled staking user rewards history button to the asset detail page for ETH. This button leads to a bar chart graph of the user rewards over a 2 year period. A user can switch to 7D, M or Y to get 7 days, monthly or yearly data in the graph and can select different bars to see the amount of that bar's time period in the chart header. Default view with no selected bars shows the total amount of rewards earned.
To add a chart view for the user to look at their historical rewards in detail
A chart view has been added that will allow the user to look at their historical rewards in detail
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
No chart or button n/a
After
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-11.at.18.47.42.mp4
Pre-merge author checklist
Pre-merge reviewer checklist