-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Decoding Simulation Metrics #13041
Conversation
- to use with react class components
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
...s/Views/confirmations/components/Confirm/SignatureBlockaidBanner/SignatureBlockaidBanner.tsx
Outdated
Show resolved
Hide resolved
Bitrise❌❌❌ Commit hash: 4dc981b Note
Tip
|
...s/Views/confirmations/components/Confirm/SignatureBlockaidBanner/SignatureBlockaidBanner.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/components/PersonalSign/PersonalSign.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/useSignatureMetrics.ts
Outdated
Show resolved
Hide resolved
...ws/confirmations/components/Confirm/SignatureBlockaidBanner/SignatureBlockaidBanner.test.tsx
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
Description
Add Decoding Simulation details to Signature request metrics
Note:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3858
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist