Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Decoding Simulation Metrics #13041

Merged
merged 17 commits into from
Jan 20, 2025
Merged

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jan 16, 2025

Description

Add Decoding Simulation details to Signature request metrics

Note:

  • Split useTypedSignSimulationEnabled logic into selectTypedSignSimulationEnabled to support React class components

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3858

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested review from a team as code owners January 16, 2025 22:12
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 16, 2025
@digiwand digiwand added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 17, 2025
Copy link
Contributor

github-actions bot commented Jan 17, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4dc981b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd1e5897-f886-4b20-a427-146ff171f31a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

@digiwand digiwand enabled auto-merge January 20, 2025 16:56
@digiwand digiwand added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit e921135 Jan 20, 2025
37 of 38 checks passed
@digiwand digiwand deleted the feat-decoding-simulation-metrics branch January 20, 2025 17:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 20, 2025
@digiwand digiwand added release-7.39.0 Issue or pull request that will be included in release 7.39.0 rc-cherry-picked and removed release-7.40.0 Issue or pull request that will be included in release 7.40.0 labels Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rc-cherry-picked release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants