Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update composable controller to v^3 #7728

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

tommasini
Copy link
Contributor

Description

This PR aims to update to the composable controller v:^3.0.0, this is part of the controller upgrade to v53.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Smoke test manual transaction on goerli
https://recordit.co/oiGROSZqiw

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner November 8, 2023 14:07
Copy link
Contributor

github-actions bot commented Nov 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title Update composable controller to v^3 feat: Update composable controller to v^3 Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7cf8c49b-9ba1-4050-b7e0-2f2fb3592ae7
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/composable-controller 2.0.0...3.0.3 None +1/-0 139 kB metamaskbot

Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76df2eb9-61f2-4ce9-a428-7464277c530b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@Cal-L Cal-L added Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed Run Smoke E2E labels Nov 8, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/098df9f0-c661-4e2a-9591-fc367fb4ecb2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tommasini tommasini merged commit ac970da into main Nov 8, 2023
@tommasini tommasini deleted the update/7487-composable-controller-update-v3 branch November 8, 2023 19:47
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
@metamaskbot metamaskbot added release-7.12.0 Issue or pull request that will be included in release 7.12.0 needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants